In the routine scan_scsis(), The following code would appear to limit
the number of luns a given apapter can use to max_scsi_luns, as opposed
to the limit the low-level driver passed in the Scsi_Host structure.
Is that the behaviour we want? or should the '<' become a '>' in the ternary,
thereby scanning the greater of the passed max_lun or the system max_scsi_luns.
It seems to me that if a low level driver passes a large number of luns,
the midlayer should accept that value.
Of course, the use of the CONFIG_SCSI_MULTI_LUN #define would lead me to
believe that the kernel does indeed want to limit the number of luns probed
to the lesser of the two values... but why??
max_dev_lun = (max_scsi_luns < shpnt->max_lun ?
max_scsi_luns : shpnt->max_lun);
sparse_lun = 0;
for (lun = 0; lun < max_dev_lun; ++lun) {
if (!scan_scsis_single(channel, order_dev, lun, &max_dev_lun,
&sparse_lun, &SDpnt, shpnt,
scsi_result)
&& !sparse_lun) break;
}
--
+==============================================================+
| James W Washer IBM NUMA-Q Service KG7HH(US) M0BOR(UK) |
| |
| 15450 SW Koll Pkwy |
| MS RHE2-501 |
| Beaverton, OR 97006 |
| |
| 1-800-854-9969 1-503-578-3171(direct line) |
| washer@us.ibm.com |
+==============================================================+
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon May 07 2001 - 21:00:19 EST