Re: [PATCH] x86 page fault handler not interrupt safe

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Mon May 07 2001 - 10:07:24 EST


> Alan Cox wrote:
> > (The current -ac fix for the double vmalloc races is below. WP test makes it
> > more complex than is nice)
>
> WP test is easy to handle. Just filter out protection violations and
> only take the vmalloc path if the page was not found.
>
> - if (address >= TASK_SIZE && !(error_code & 4))
> + if (address >= TASK_SIZE && !(error_code & 5))

That is nice. I hadn't thought about doing it that way. It still has the problem
if %cr2 is corrupted by a vmalloc fault but it cleans up my other code paths
nicely.

Thanks

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 07 2001 - 21:00:24 EST