Trond Myklebust writes:
> IMHO allocating the buffer using GFP_ATOMIC is a mistake. As I said
> we're in a thread context, so sleeping in GFP_KERNEL is safe. In
> addition, the cost of dropping the request if we can't allocate the
> buffer is heavy in that the client has to wait for a timeout, and then
> retry.
>
> I'd therefore like to propose the following change.
...
> --- linux-2.4.4/net/sunrpc/svcsock.c.orig Fri Apr 27 23:15:01 2001
> +++ linux-2.4.4/net/sunrpc/svcsock.c Fri May 11 10:08:36 2001
...
> - if (skb_linearize(skb, GFP_ATOMIC) != 0) {
> + if (skb_linearize(skb, GFP_KERNEL) != 0) {
No arguments here.
Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue May 15 2001 - 21:00:25 EST