Re: PATCH: more esssolo1 cleanups

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Tue May 22 2001 - 12:45:09 EST

Next message: Oliver Xymoron: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
Previous message: Alexander Viro: "Re: [PATCH] struct char_device"
In reply to: Marcus Meissner: "PATCH: more esssolo1 cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Looks ok. General comment: the code to search through the list of PCI
devices and drivers to find the one associated with our minor should be
in a separate function, if that code appears more than once.
esssolo_find_minor or somesuch...

-- 
Jeff Garzik      | "Are you the police?"
Building 1024    | "No, ma'am.  We're musicians."
MandrakeSoft     |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Oliver Xymoron: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
Previous message: Alexander Viro: "Re: [PATCH] struct char_device"
In reply to: Marcus Meissner: "PATCH: more esssolo1 cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 23 2001 - 21:00:47 EST