At 3:30 PM +0100 2001-05-24, Alan Cox wrote:
> > > - printk(version);
>> > + printk("%s", version);
>> >
>> Could you please explain the purpose of this change? To me it looks less
>> efficient in both performance and memory usage.
>
>its called 'programming in C not taking ugly shortcuts'
>>
Fine. But:
At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
>- printk(version);
>+#ifdef MODULE
>+ printk("s", version);
> printed_version = 1;
>+#endif /* MODULE */
...is playing it just a little too safe, wouldn't you say?
I assume that MODULE ifdef is related to version being initdata otherwise?
-- /Jonathan Lundell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:17 EST