Re: [PATCH] warning fixes for 2.4.5pre5

From: Juan Quintela (quintela@mandrakesoft.com)
Date: Fri May 25 2001 - 10:13:39 EST

Next message: Eric W. Biederman: "Re: DVD blockdevice buffers"
Previous message: Jens Axboe: "Re: PS/2 Esdi patch #8"
In reply to: Rich Baum: "[PATCH] warning fixes for 2.4.5pre5"
Next in thread: Alan Cox: "Re: [PATCH] warning fixes for 2.4.5pre5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> --- linux/arch/i386/math-emu/fpu_trig.c Fri Apr 6 12:42:47 2001
> +++ rb/arch/i386/math-emu/fpu_trig.c Tue May 22 16:44:57 2001
> @@ -1543,6 +1543,7 @@
> EXCEPTION(EX_INTERNAL | 0x116);
> return;
> #endif /* PARANOID */
>+ return;
> }
> }
> else if ( (st0_tag == TAG_Valid) || (st0_tag == TW_Denormal) )

Will not be better to move the return out of the #endif PARANOID?
Otherwise you get 2 returns when you have defined paranoid ...

> --- linux/drivers/scsi/sym53c8xx.c Fri Apr 27 15:59:19 2001
> +++ rb/drivers/scsi/sym53c8xx.c Tue May 22 16:45:03 2001
> @@ -11564,6 +11564,7 @@
> OUTL_DSP (NCB_SCRIPT_PHYS (np, clrack));
> return;
> out_stuck:
>+ return;
> }

same

Later,Juan.

-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Eric W. Biederman: "Re: DVD blockdevice buffers"
Previous message: Jens Axboe: "Re: PS/2 Esdi patch #8"
In reply to: Rich Baum: "[PATCH] warning fixes for 2.4.5pre5"
Next in thread: Alan Cox: "Re: [PATCH] warning fixes for 2.4.5pre5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:23 EST