[PATCH] add restore_flags to error path in irttp.c (245ac1)

• Next message: Daniel Phillips: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
• Previous message: Ben LaHaise: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi.

The following patch makes irttp_read_proc restore_flags()
in error cases too. Applies against 245ac1.

--- linux-245-ac1-clean/net/irda/irttp.c Sun May 27 22:15:34 2001
+++ linux-245-ac1/net/irda/irttp.c Sun May 27 22:37:59 2001
@@ -1598,7 +1598,7 @@
         self = (struct tsap_cb *) hashbin_get_first(irttp->tsaps);
         while (self != NULL) {
                 if (!self || self->magic != TTP_TSAP_MAGIC)
- return len;
+ break;
 
                 len += sprintf(buf+len, "TSAP %d, ", i++);
                 len += sprintf(buf+len, "stsap_sel: %02x, ",

-- 
Regards,
        Rasmus(rasmus@jaquet.dk)
Which is worse: Ignorance or Apathy?
Who knows? Who cares?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Daniel Phillips: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
• Previous message: Ben LaHaise: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:34 EST