Re: [PATCH] net #6

From: Andrzej Krzysztofowicz (ankry@green.mif.pg.gda.pl)
Date: Wed May 30 2001 - 05:35:17 EST

Next message: Studierende der Universitaet des Saarlandes : "Re: [PATCH] net"
Previous message: Keith Owens: "Re: [CHECKER] 4 security holes in 2.4.4-ac8"
In reply to: Alan Cox: "Re: [PATCH] net #6"
Next in thread: Pavel Machek: "Re: [PATCH] net #6"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>
> > The following patch removes unnecessary #ifdefs from eexpress.c
>
> They are neccessary

Yes, you are right.
I was suggested by improper part of spinlock.h ...

Forget this patch.

> > @@ -643,9 +631,7 @@
> > eexp_hw_tx_pio(dev,data,length);
> > }
> > dev_kfree_skb(buf);
> > -#ifdef CONFIG_SMP
> > spin_unlock_irqrestore(&lp->lock, flags);
> > -#endif
> > enable_irq(dev->irq);
> > return 0;
>
> They are done this way to get good non SMP performance. Your changes would
> ruin that.

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  tel.  (0-58) 347 14 61
Wydz.Fizyki Technicznej i Matematyki Stosowanej Politechniki Gdanskiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Studierende der Universitaet des Saarlandes : "Re: [PATCH] net"
Previous message: Keith Owens: "Re: [CHECKER] 4 security holes in 2.4.4-ac8"
In reply to: Alan Cox: "Re: [PATCH] net #6"
Next in thread: Pavel Machek: "Re: [PATCH] net #6"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:45 EST