cscope:
Minor stuff:
1) in cscope.files - I'd be replacing cscope.files with $@ within the rule -
you don't need a yellow belt to know $@ within a Makefile
2) /bin/rm vs rm
tags: Not going deep into it, I possibly should say here that hardwiring
depth 5 is not the best thing probably - once someone extends down to 6,
this place in the Makefile will for sure not be updated. You can make a loop
here to max depth, which you can discover right here, rather than the
current manually unrolled loop.
In general, I am not a tags user in the kernel (sticking to local tags +
global cscope), so I'd be happy if you and
Pete could merge together your tags stuff. As for the ignore list, I don't
see much of maintenance work there - and, if you guys think there is, maybe
it is just possible to add Pete on the Kernel Build maintainers WRT to that
file?
Overall, IMHO, after you give it the last touch (maybe just dismissing my
present letter :-) ) the cscope stuff is mature enough for going to KO & Co.
(i.e. the kernel build guys); I don't consider myself a hardcore tags user
to say so about the tags portion.
Keith, what do you think?
Vassilii
> -----Original Message-----
> From: Mark Frazer [mailto:mark@somanetworks.com]
> Sent: Thursday, May 31, 2001 4:45 PM
> To: Khachaturov, Vassilii
> Cc: Linux Kernel
> Subject: Re: Makefile patch for cscope and saner Ctags
>
>
> Khachaturov, Vassilii <Vassilii.Khachaturov@comverse.com>
> [01/05/31 15:00]:
> > Don't forget to bug RH package maintainer on that. Whatever
>
> bugzilla submitted
>
> > I use source-built cscope v.15.1, and -k works for me here,
>
> works for me too!
>
> > WHY?! Isn't it better to put $(shell cat cscope.files) on
> the list of
>
> I only have a yellow belt in makefile kungfu. These fancy
> gnu make things
> are relatively new to some of us...
>
> The latest patch is attached. include/linux/compile.h seems to get
> built whenever I run make, so that's why I've excluded it
> from the deps
> for cscope.out.
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Jun 07 2001 - 21:00:17 EST