Re: [PATCH] skb destructor enhancement idea

From: Will (will@egregious.net)
Date: Mon Jun 25 2001 - 17:50:16 EST


David S. Miller wrote:
> I think the idea totally stinks.

The idea, or just the performance implications of my particular implementation? If
this could be done without a global spinlock would you still object to the
construction of the small linked list in each skb?

> Add an ifdef and the knobs you need to the skb struct directly just
> like netfilter does.

So I should #ifdef throughout the tcp and socket code wherever skb's 'destructor' is
called to call mine as well? And multiply that by N driver writers who'd like to do
the same thing? Sounds messy...

-- 
-Will  :: AD6XL :: http://tyranny.egregious.net/~will/
 Orton :: finger will@tyranny.egregious.net for GPG public key
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 30 2001 - 21:00:13 EST