Re: [PATCH] (comments requested) adding finer-grained timing to PPC add_timer_randomness()

From: Ignacio Vazquez-Abrams (ignacio@openservices.net)
Date: Wed Aug 22 2001 - 16:06:31 EST

On Wed, 22 Aug 2001, Chris Friesen wrote:

> I'd like some comments on the following patch.
>
> This patch is designed to add finer-grained timing (similar to the i386 timing)
> to add_timer_randomness(). The only tricky bit is that the PPC601 doesn't
> support the timebase registers. Accordingly, I've added a flag to the PPC port
> that is used to keep track of whether or not the processor supports the timebase
> register.
>
> Is there a better way to keep track of this information? i386 has a struct with
> useful information stored, but it doesn't look like PPC does.
>
> Thanks,
>
> Chris

>From the patch:

--- linux-2.2.19-clean/arch/ppc/kernel/setup.c Sun Mar 25 11:31:49 2001
+++ linux-2.2.19/arch/ppc/kernel/setup.c Wed Aug 22 16:34:51 2001
  ...
+extern int have_timebase = 1;
  ...
--- linux-2.2.19-clean/include/asm-ppc/processor.h Sun Mar 25 11:31:08 2001
+++ linux-2.2.19/include/asm-ppc/processor.h Wed Aug 22 16:34:51 2001
  ...
+extern int have_timebase;
  ...

Hrmm...

Am I missing something, or should at least one of these not be extern? 

-- 
Ignacio Vazquez-Abrams  <ignacio@openservices.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Aug 23 2001 - 21:00:51 EST