On Thu, Sep 20, 2001 at 11:57:02AM +0200, Martin MOKREJŠ wrote:
> . scripts/mkversion > .version
People,
As I'm sure you're all aware, being experts in userland programming, that
the above obviously cannot work and is totally bogus.
The mkversion script contains:
if [ ! -f .version ]
then
echo 1
else
expr 0`cat .version` + 1
fi
but wait! As far as the script is concerned, .version will always exist
because its created before the script is run (the open occurs, the file is
truncated, and passed to the script as STDOUT).
This has a nice effect - the build number of the kernel is now fixed at '1'.
So, why don't we get rid of the above crap and just do "echo 1 > .version"
and be done with it? ;)
Alternatively, the following patch fixes things such that we can read the
original .version file within the script, if it existed prior to invocation,
and produce the correct build number.
Note that as illustrated by the previous poster, -linus now has the problem,
and -ac also has the same. The following patch was generated against
2.4.9-ac10, but should apply to both trees without problem.
--- ref/Makefile Wed Sep 19 14:00:24 2001
+++ linux/Makefile Thu Sep 20 11:19:43 2001
@@ -234,7 +234,7 @@
drivers/sound/pndsperm.c \
drivers/sound/pndspini.c \
drivers/atm/fore200e_*_fw.c drivers/atm/.fore200e_*.fw \
- .version .config* config.in config.old \
+ .version* .config* config.in config.old \
scripts/tkparse scripts/kconfig.tk scripts/kconfig.tmp \
scripts/lxdialog/*.o scripts/lxdialog/lxdialog \
.menuconfig.log \
@@ -306,7 +306,8 @@
$(TOPDIR)/include/linux/compile.h: include/linux/compile.h
newversion:
- . scripts/mkversion > .version
+ . scripts/mkversion > .version.tmp
+ @mv -f .version.tmp .version
include/linux/compile.h: $(CONFIGURATION) include/linux/version.h newversion
@echo -n \#define UTS_VERSION \"\#`cat .version` > .ver
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:37 EST