Re: [PATCH] fix page aging (2.4.9-ac12)

From: Daniel Phillips (phillips@bonn-fries.net)
Date: Thu Sep 20 2001 - 08:32:26 EST


On September 19, 2001 08:40 pm, Jan Harkes wrote:
> On Wed, Sep 19, 2001 at 03:25:29PM -0300, Rik van Riel wrote:
> > No more mr. overcareful, obviously that doesn't work ;)
>
> Finally ;)
>
> > static inline void age_page_down(struct page *page)
> > {
> ...
> > + unsigned long age = page->age;
> > + if (age > 0)
> > + age -= PAGE_AGE_DECL;
> > + page->age = age;
> > }
>
> Perhaps the following would be better, just in case anyone sets
> PAGE_AGE_DECL to something other than 1.
>
> static inline void age_page_down(struct page *page)
> {
> unsigned long age = page->age;
> if (age > PAGE_AGE_DECL)
> age -= PAGE_AGE_DECL;
> else
> age = 0;
> page->age = age;
> }

     static inline void age_page_down(struct page *page)
     {
         page->age = max((int) (age - PAGE_AGE_DECL), 0);
     }

;-)

--
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:37 EST