PATCH: linux-2.4.10-pre14/drivers/net/tlan.c ignored pci_module_init result

From: Adam J. Richter (adam@yggdrasil.com)
Date: Sun Sep 23 2001 - 01:20:37 EST

Next message: Adam J. Richter: "PATCH: linux-2.4.10-pre14/drviers/net/irda/toshoboe.c module segfaults at removal if hardware absent"
Previous message: Ben Greear: "pre15 modules compile problem:"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

linux-2.4.10-pre4/drivers/net/tlan.c incorrectly used
pci_module_init instead of pci_register_module. pci_module_init will
unregister the PCI driver if no matching hardware is found and the
driver is compiled as a module. However, the driver may still remain
loaded is there is an EISA tlan device present. If a PCI tlan device
were subsequently plugged in, then the module would not handle it
because the PCI driver is not registered, and the module would not
be reloaded, because the module is already loaded to handle the
EISA device.

What should happen, is that the PCI driver should remain
registered unless the module is going to be unloaded, which is
what this patch does.

-- Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104 adam@yggdrasil.com \ / San Jose, California 95129-1034 +1 408 261-6630 | g g d r a s i l United States of America fax +1 408 261-6631 "Free Software For The Rest Of Us."

text/plain attachment: tlan.diff

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Adam J. Richter: "PATCH: linux-2.4.10-pre14/drviers/net/irda/toshoboe.c module segfaults at removal if hardware absent"
Previous message: Ben Greear: "pre15 modules compile problem:"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:52 EST