Re: [PATCH] PART1: Proposed init & module changes for 2.5

From: Keith Owens (kaos@ocs.com.au)
Date: Sun Sep 23 2001 - 20:01:29 EST


On Mon, 24 Sep 2001 08:42:25 +1000,
Rusty Russell <rusty@rustcorp.com.au> wrote:
>In message <20010923124336.D30515@nightmaster.csn.tu-chemnitz.de> you write:
>> Can the startcall or the initcall still be called after stopcall?
>
>No: at this stage the module will have to be reloaded, exactly because
>of assumptions like zero-initialization.

When we discussed this at linux.conf.au in Sydney, we agreed that we
could call startfn after stopfn to handle the quiesce unload algorithm.
That handles the rmmod race without exporting mod use count to
everything, i.e.

  rmmod
  if use count == 0, call stopfn()
    synchronize_kernel()
    if use count == 0, exitfn()
    if use count != 0, startfn()

That catches the race where a second cpu has entered the module but not
done MOD_INC_USECOUNT yet. The module is now in use but stopfn has
been called, the best thing to do is accept that rmmod lost the race
and reinstate the module.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:55 EST