Re: highmem deadlock fix [was Re: VM in 2.4.10(+tweaks) vs. 2.4.9 -ac14/15(+stuff)]

From: Andrea Arcangeli (andrea@suse.de)
Date: Thu Sep 27 2001 - 17:37:46 EST


On Thu, Sep 27, 2001 at 05:34:17PM -0500, Robert_Macaulay@Dell.com wrote:
>
>
> > -----Original Message-----
> > From: Andrea Arcangeli [mailto:andrea@suse.de]
> > Sent: Thursday, September 27, 2001 5:13 PM
> > To: Macaulay, Robert
> > Cc: Rik van Riel; Craig Kulesa; linux-kernel@vger.kernel.org; Bob
> > Matthews; Marcelo Tosatti; Linus Torvalds
> > Subject: highmem deadlock fix [was Re: VM in 2.4.10(+tweaks) vs.
> > 2.4.9-ac14/15(+stuff)]
> >
> > @@ -2519,7 +2521,9 @@
> > int tryagain = 1;
> >
> > do {
> > - if (buffer_dirty(p) || buffer_locked(p)) {
> > + if (unlikely(buffer_pending_IO(p)))
> > + tryagain = 0;
> > + else if (buffer_dirty(p) || buffer_locked(p)) {
> > if (test_and_set_bit(BH_Wait_IO, &p->b_state)) {
> > if (buffer_dirty(p)) {
> > ll_rw_block(WRITE, 1, &p);
> >
>
> Im getting an undefined reference to the unlikely function in this patch.

ok, try adding #include <linux/compiler.h> to include/linux/kernel.h, I
prefer to have likely/unlikely always available.

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 30 2001 - 21:00:58 EST