hi all,
Al - is the attached patch more along the lines of what you
were after?
Jan - I think this is actually alot closer to what you were
talking about when we last discussed this. Can you see any
problems from a VFS quota point of view here? I had to make
small interface changes to a couple of the dquot.c routines
to make this simpler/more uniform in places - could you have
cross-check those for me?
many thanks.
On Sat, Oct 06, 2001 at 02:25:06PM -0400, Alexander Viro wrote:
>
>
> On Sat, 6 Oct 2001, Jan Kara wrote:
>
> > Hello,
> >
> > I'm sending you a change for quotactl interface which Nathan Scott proposed
> > for XFS. Actually it's his patch with just a few changes from me.
> > It allows quotactl() to be overidden by a filesystem and so XFS can do it's
> > tricks with quota without patching dquot.c. Sideeffect of this change is a
> > cleanup in quotactl() interface :).
>
> [snip]
>
> Umm... So you've just given to each fs driver a syscall with
> completely unspecified arguments? I _really_ doubt that it's a good
> idea, especially since each instance will have to copy structures
> to/from userland.
>
> Please, put switch by the first argument and copy_{to,from}_user()
> into the syscall itself. Yes, it means more methods, but it helps to avoid
> large PITA couple of years down the road.
>
-- Nathan
This archive was generated by hypermail 2b29 : Mon Oct 15 2001 - 21:00:17 EST