Re: [patch] block highmem zero-bounce #17

From: Andreas Schwab (schwab@suse.de)
Date: Fri Oct 19 2001 - 08:08:12 EST

Next message: Andrey Panin: "[PATCH] MODULE_DEVICE_TABLE for Applicom fieldbus card driver"
Previous message: Rik van Riel: "Re: [RFC][PATCH] free more swap space on exit()"
In reply to: Jens Axboe: "[patch] block highmem zero-bounce #17"
Next in thread: Jens Axboe: "Re: [patch] block highmem zero-bounce #17"
Reply: Jens Axboe: "Re: [patch] block highmem zero-bounce #17"
Reply: Jens Axboe: "Re: [patch] block highmem zero-bounce #17"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Jens Axboe <axboe@suse.de> writes:

|> Patch is considered solid. Find it here:
|>
|> *.kernel.org/pub/linux/kernel/people/axboe/patches/2.4.13-pre4/block-highmem-all-17.bz2

Your patch still makes bad use of struct scatterlist which is architecture
dependent. Either fix the definitions in asm-*/scatterlist.h or go back
using a private struct. Why did you switch to struct scatterlist in the
first place??

Andreas.

-- 
Andreas Schwab                                  "And now for something
Andreas.Schwab@suse.de				completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Andrey Panin: "[PATCH] MODULE_DEVICE_TABLE for Applicom fieldbus card driver"
Previous message: Rik van Riel: "Re: [RFC][PATCH] free more swap space on exit()"
In reply to: Jens Axboe: "[patch] block highmem zero-bounce #17"
Next in thread: Jens Axboe: "Re: [patch] block highmem zero-bounce #17"
Reply: Jens Axboe: "Re: [patch] block highmem zero-bounce #17"
Reply: Jens Axboe: "Re: [patch] block highmem zero-bounce #17"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Oct 23 2001 - 21:00:23 EST