Re: [PATCH] don't reset alarm interrupt on RTC

From: Tim Hockin (thockin@sun.com)
Date: Wed Oct 31 2001 - 17:34:57 EST

Next message: Alex Bligh - linux-kernel: "RE: 2xQ: Is PM + ACPI but /no/ APM a valid configuration? Interru pts enabled in APM set power state?"
Previous message: andersg@0x63.nu: "Re: Local APIC option (CONFIG_X86_UP_APIC) locks up Inspiron 8100"
In reply to: Patrick Mochel: "Re: [PATCH] don't reset alarm interrupt on RTC"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Patrick Mochel wrote:

> - tmp &= ~RTC_AIE;
> + //tmp &= ~RTC_AIE;
> tmp &= ~RTC_UIE;
> CMOS_WRITE(tmp, RTC_CONTROL);
> CMOS_READ(RTC_INTR_FLAGS);

> Why would you want to unconditionally enable this interrupt?

We don't unconditionally set it, we just leave it enabled (the code was
uncoditionally UNsetting it). There are ioctl()s to set/unset PIE, AIE,
UIE.

> And how do you set the alarm time?

ioctl(fd, RTC_ALM_SET);

> But, I don't think this should be enabled by default.

if anything, our patch is not correct ENOUGH. none of AIE, PIE, or UIE,
should be molested by rtc_release().

-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Alex Bligh - linux-kernel: "RE: 2xQ: Is PM + ACPI but /no/ APM a valid configuration? Interru pts enabled in APM set power state?"
Previous message: andersg@0x63.nu: "Re: Local APIC option (CONFIG_X86_UP_APIC) locks up Inspiron 8100"
In reply to: Patrick Mochel: "Re: [PATCH] don't reset alarm interrupt on RTC"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Oct 31 2001 - 21:00:46 EST