Re: [PATCH] Adding KERN_INFO to some printks #2

From: John Levon (moz@compsoc.man.ac.uk)
Date: Sat Nov 10 2001 - 08:44:34 EST

Next message: Alan Cox: "Re: scsi BLKGETSIZE breakage in -pre2"
Previous message: David S. Miller: "Re: speed difference between using hard-linked and modular drives?"
In reply to: Robert Love: "Re: [PATCH] Adding KERN_INFO to some printks #2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Nov 09, 2001 at 04:45:48PM -0500, Robert Love wrote:

> I went over the patch and found a few things...
>
> printk(KERN_INFO "No local APIC present or hardware disabled\n");
>
> I'd make this a KERN_WARNING. Consider the case where I compile my own
> kernel and I add APIC support. If the driver is failing to find my APIC
> then either (a) my BIOS is broken or (b) I should remove the driver.
> Either way I would want to know.

This isn't what's happening - check apic.c. It is re-enabled if possible,
or a local APIC really doesn't exist. Either way I don't see the point
in a warning.

regards
john

-- 
"I know I believe in nothing but it is my nothing"
	- Manic Street Preachers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Alan Cox: "Re: scsi BLKGETSIZE breakage in -pre2"
Previous message: David S. Miller: "Re: speed difference between using hard-linked and modular drives?"
In reply to: Robert Love: "Re: [PATCH] Adding KERN_INFO to some printks #2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 15 2001 - 21:00:24 EST