Re: [PATCH] OOPS in i810_audio during resume

• Next message: Wolfgang Rohdewald: "Re: Swap"
• Previous message: Ingo Saitz: "Re: radeonfb bug: text ends up scrolling in the middle of tux."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello

When resuming from APM suspend with the i810_audio loaded I got an OOPS that
killed apmd. This simple patch stops the OOPS (so APM keeps working) but it
doesn't solve the problem.

'codec' is null is because it previously failed to initialise in
i810_ac97_init: i810_ac97_probe_and_powerup fails for the second codec; Alex
Bligh mentioned this a few weeks ago.

--- /usr/src/linux/drivers/sound/i810_audio.c.orig Thu Nov 15 01:38:31 2001
+++ /usr/src/linux/drivers/sound/i810_audio.c Thu Nov 15 01:45:07 2001
@@ -2873,6 +2873,10 @@
                if(!i810_ac97_exists(card,num_ac97)) {
                        if(num_ac97) continue;
                        else BUG();
+ }
+ if(!codec) {
+ printk("i810_audio: cannot resume null codec %d\n", num_ac97);
+ continue;
                }
                if(!i810_ac97_probe_and_powerup(card,codec)) BUG();
 

-- 
Marty
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Wolfgang Rohdewald: "Re: Swap"
• Previous message: Ingo Saitz: "Re: radeonfb bug: text ends up scrolling in the middle of tux."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 23 2001 - 21:00:24 EST