Re: 2.4.14/2.4.15 cpia driver IS broke.. no its parport

From: Joe (joeja@mindspring.com)
Date: Sun Nov 25 2001 - 14:08:59 EST


In that case I'ss send my patch to 2.4.14 to the list and hope it helps others
with their parallel port webcams.. (its small)

Joe

> This works perfectly for my w9966 parport webcam!
> /Jakob
>
> On Saturdayen den 24 November 2001 22.43, Jakob Kemi wrote:
> > Great!
> >
> > I'll test it right away.
> > /Jakob
> >
> > > The problem is that in the call to acknowledge the handshake (Event 44?
> > > about line592) the call to parport_frob_control or
> > > parport_pc_frob_control as it is #defined to is called with a 0 which I
> > > think causes the code to call parport_pc_data_forward and the new code
> > > just calls
> > > parport_pc_data_reverse. I think that we may need to call the
> > > parport_pc_data_forward still.
> > >
> > > - parport_write_control (port, ctl); // new code
> > > + parport_frob_control (port, PARPORT_CONTROL_AUTOFD, 0);
> > > //old working code
> > >
> > > Joe
> > >
>


--- linux-2.4.14/drivers/parport/ieee1284_ops.c Fri Nov 23 20:59:42 2001
+++ linux-2.4.current/drivers/parport/ieee1284_ops.c Sun Nov 18 21:13:10 2001
@@ -592,7 +592,7 @@
                 }
 
                 /* Event 44: Set HostAck high, acknowledging handshake. */
- parport_write_control (port, ctl);
+ parport_frob_control (port, PARPORT_CONTROL_AUTOFD, 0);
 
                 /* Event 45: The peripheral has 35ms to set nAck high. */
                 if (parport_wait_peripheral (port, PARPORT_STATUS_ACK,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 30 2001 - 21:00:19 EST