Re: [PATCH] Scalable page cache

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Nov 26 2001 - 17:23:02 EST


On Mon, 26 Nov 2001, Andrew Morton wrote:
>
> We've called block_prepare_write(), which has done the kmap.
> But even though block_prepare_write() returned success, this
> call to the filesystem's ->prepare_write() is about to fail.

That's _way_ too intimate knowledge of how block_prepare_write() works (or
doesn't work).

How about sending me a patch that removes all the kmap/kunmap crap from
_both_ ext3 and block_prepare/commit_write.

> There have been a number of mistakes made over this particular kmap()
> operation. NFS client had it wrong for a while. I think sct had
> some proposal for making it more robust.

It _is_ more robust. You are only battling remnants from an older age when
it wasn't.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 30 2001 - 21:00:24 EST