Re: PATCH 2.5.1.4: fix rd.c build

From: Jens Axboe (axboe@suse.de)
Date: Fri Nov 30 2001 - 02:28:55 EST

Next message: Miles Lane: "2.5.0-pre4 -- ide-tape.c:1512: structure has no member named `b_reqnext'"
Previous message: Ahmed Masud: "Too buggy even for Linux [Was Re: some questions about wedding]"
In reply to: Alexander Viro: "Re: PATCH 2.5.1.4: fix rd.c build"
Next in thread: Alexander Viro: "Re: PATCH 2.5.1.4: fix rd.c build"
Reply: Alexander Viro: "Re: PATCH 2.5.1.4: fix rd.c build"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Nov 30 2001, Alexander Viro wrote:
>
>
> On Fri, 30 Nov 2001, Jens Axboe wrote:
>
> > Actually, this is not even enough if rd receives a multi page bio.
> > Something like this should work, untested.
> >
> > @@ -237,9 +238,9 @@
> > err = -EIO;
>
> Make it err = 0...

Explain

> Another thing being, if you remove explicit call of rd_init() from
> ll_rw_blk.c making module_init() unconditional looks like a good
> idea...

Indeed, done.

-- Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Miles Lane: "2.5.0-pre4 -- ide-tape.c:1512: structure has no member named `b_reqnext'"
Previous message: Ahmed Masud: "Too buggy even for Linux [Was Re: some questions about wedding]"
In reply to: Alexander Viro: "Re: PATCH 2.5.1.4: fix rd.c build"
Next in thread: Alexander Viro: "Re: PATCH 2.5.1.4: fix rd.c build"
Reply: Alexander Viro: "Re: PATCH 2.5.1.4: fix rd.c build"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 30 2001 - 21:00:37 EST