Re: [LART] pc_keyb.c changes

From: David C. Hansen (dave@sr71.net)
Date: Fri Nov 30 2001 - 16:34:43 EST

Next message: Denis Zaitsev: "[PATCH] mm/swapfile.c/get_swaparea_info - a cosmetic change"
Previous message: Jens Axboe: "Re: Compile fixes for 2.5.1-pre4"
In reply to: Alexander Viro: "[LART] pc_keyb.c changes"
Next in thread: george anzinger: "Re: [LART] pc_keyb.c changes"
Reply: george anzinger: "Re: [LART] pc_keyb.c changes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Alexander Viro wrote:

> Could the person who switched from BKL to spin_lock_irqsave() in
> pc_keyb.c please share whatever the hell he had been smoking? Free clue:
> disabling interrupts for long intervals to improve scalability is right up
> there with fighting for peace and fucking for virginity.
As I slowly raise my hand to take, um credit....

This is definitely one of the drivers I to take a second look at, now
that I know about the BKL being held for block and char device opens.
Do you have any ideas how else to do this safely since aux_count is
referenced during an interrupt?

-- Dave Hansen dave@sr71.net

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Denis Zaitsev: "[PATCH] mm/swapfile.c/get_swaparea_info - a cosmetic change"
Previous message: Jens Axboe: "Re: Compile fixes for 2.5.1-pre4"
In reply to: Alexander Viro: "[LART] pc_keyb.c changes"
Next in thread: george anzinger: "Re: [LART] pc_keyb.c changes"
Reply: george anzinger: "Re: [LART] pc_keyb.c changes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 30 2001 - 21:00:40 EST