Re: [PATCH] direct IO breaks root filesystem

From: Linus Torvalds (torvalds@transmeta.com)
Date: Tue Dec 11 2001 - 19:34:15 EST


On Wed, 12 Dec 2001, Tachino Nobuhiro wrote:
>
> Your patch will break Goto's fix because mapping->host does not have
> correct i_mode.

Note that Goto's fix really is quite _fundamentally_ broken. Don't use it.

As explained in another email, you really should use the set-block-size
ioctl to set the correct blocksize for the device you are using. That
should work fine once the correct inode is used by the direct_io code..

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 15 2001 - 21:00:22 EST