On Sun, 23 Dec 2001, James Bottomley wrote:
> Since the architecture support depends fairly intimitely on the existing i386
> code, I've slotted it into the i386 architecture directory rather than trying
> to create a separate one.
> http://www.hansenpartnership.com/voyager/files/voyager-2.5.1.diff
> All comments welcome.
Things like this...
+#ifdef CONFIG_VOYAGER
+ }
+#endif
*really* gross me out. One thing I intend to do at some point in
2.5 also is to split out the visws setup code to setup-visws.c or
the likes, as a, it's more or less unmaintained, and b, more
noisy ifdef's.
I'd be *so* much happier to see your patch with setup-voyager.c,
and a single ifdef in setup.c wrapping setup_voyager() or the likes.
On another related topic, the bootmem stuff in setup.c would be
so much nicer to be split into a bootmem.c imho.
This would also make sharing the x86 bootmem code with the x86-64
bootmem code a lot simpler.
comments ?
Dave.
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Dec 23 2001 - 21:00:31 EST