Extern variables in *.c files

From: vda (vda@port.imtp.ilyichevsk.odessa.ua)
Date: Wed Jan 02 2002 - 13:18:04 EST

Next message: Greg KH: "Re: Deadlock in kernel on USB shutdown"
Previous message: Simon Richter: "Re: bug ?"
Next in thread: Oliver Xymoron: "Re: Extern variables in *.c files"
Reply: Oliver Xymoron: "Re: Extern variables in *.c files"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I grepped kernel *.c (not *.h!) files for extern variable definitions.
Much to my surprize, I found ~1500 such defs.

Isn't that bad C code style? What will happen if/when type of variable gets
changed? (int->long).

I thought external definitions ought to be in *.h files.
Maybe I'm missing something here...

--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Greg KH: "Re: Deadlock in kernel on USB shutdown"
Previous message: Simon Richter: "Re: bug ?"
Next in thread: Oliver Xymoron: "Re: Extern variables in *.c files"
Reply: Oliver Xymoron: "Re: Extern variables in *.c files"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:17 EST