Re: [patch] truncate fixes

From: Daniel Phillips (phillips@bonn-fries.net)
Date: Mon Jan 07 2002 - 07:41:28 EST

Next message: Daniel Phillips: "Re: [PATCH] updated version of radix-tree pagecache"
Previous message: William Lee Irwin III: "Re: [PATCH] hashed waitqueues, somewhat cleaner"
In reply to: Andrew Morton: "Re: [patch] truncate fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On January 7, 2002 05:28 am, Andrew Morton wrote:
> Andrea Arcangeli wrote:
> >
> > > (I think I'll add a buffer_mapped() test to this code as well. It's
> > > a bit redundant because the fs shouldn't go setting BH_New and not
> > > BH_Mapped, but this code is _very_ rarely executed, and I haven't
> > > tested all filesystems...)
> >
> > correct, it shouldn't be necessary. I wouldn't add it. if a fs breaks the
> > buffer_new semantics it's the one that should be fixed methinks.
>
> You mean "don't be lazy. Audit all the filesystems"? Sigh. OK.

Isn't this a job for BUG?

--
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Daniel Phillips: "Re: [PATCH] updated version of radix-tree pagecache"
Previous message: William Lee Irwin III: "Re: [PATCH] hashed waitqueues, somewhat cleaner"
In reply to: Andrew Morton: "Re: [patch] truncate fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:34 EST