Re: [andrewg@tasmail.com: remote memory reading through tcp/icmp]

From: Dave Jones (davej@suse.de)
Date: Sun Jan 20 2002 - 21:12:11 EST

On Sun, Jan 20, 2002 at 05:52:04PM -0800, David S. Miller wrote:
> Pretty simple to fix, from Andi Kleen:
>
> --- linux-work/net/ipv4/icmp.c-o Tue Jan 15 11:05:17 2002
> +++ linux-work/net/ipv4/icmp.c Sun Jan 20 23:31:29 2002
> @@ -495,7 +495,7 @@
> icmp_param.data.icmph.checksum=0;
> icmp_param.csum=0;
> icmp_param.skb=skb_in;
> - icmp_param.offset=skb_in->nh.raw - skb_in->data;
> + icmp_param.offset=skb_in->data - skb_in->nh.raw;

 With this fix, I'm seeing lots of really strange things happen.
 When eth0 comes up, the box slows down to a crawl.
 5 minutes later when it gets to starting NIS, the
 broadcast address is bombed with portmap connections. 

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Jan 23 2002 - 21:00:41 EST