[patch] dqcache receives uneven shrink_caches priority

From: Josh MacDonald (jmacd@CS.Berkeley.EDU)
Date: Mon Jan 28 2002 - 11:10:17 EST

Next message: Yann E. MORIN: "Assertion failure / do_get_write_acess() / loop / samba"
Previous message: Ingo Molnar: "Re: [patch] [sched] load-balancer improvements, 2.5.3-pre5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

It looks like the vmscan shrink_caches() function applies an uneven
priority for the call to shrink_dqcache_memory(). Instead of passing
the 'priority' argument as with the dcache and icache, dqcache always
receives the lowest (default) priority. This seems unjustified...

-josh

diff -cr mm.2.5.2/vmscan.c mm/vmscan.c
*** mm.2.5.2/vmscan.c Mon Jan 28 18:56:38 2002
--- mm/vmscan.c Mon Jan 28 18:56:50 2002
***************
*** 578,584 ****
          shrink_dcache_memory(priority, gfp_mask);
          shrink_icache_memory(priority, gfp_mask);
  #ifdef CONFIG_QUOTA
! shrink_dqcache_memory(DEF_PRIORITY, gfp_mask);
  #endif

          return nr_pages;
--- 578,584 ----
          shrink_dcache_memory(priority, gfp_mask);
          shrink_icache_memory(priority, gfp_mask);
  #ifdef CONFIG_QUOTA
! shrink_dqcache_memory(priority, gfp_mask);
  #endif

          return nr_pages;

-- 
PRCS version control system    http://sourceforge.net/projects/prcs
Xdelta storage & transport     http://sourceforge.net/projects/xdelta
Need a concurrent skip list?   http://sourceforge.net/projects/skiplist
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Yann E. MORIN: "Assertion failure / do_get_write_acess() / loop / samba"
Previous message: Ingo Molnar: "Re: [patch] [sched] load-balancer improvements, 2.5.3-pre5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:00:48 EST