On Mon, Jan 28 2002, Richard Gooch wrote:
> Jens Axboe writes:
> > On Mon, Jan 28 2002, Richard Gooch wrote:
> > > Jens Axboe writes:
> > > > On Sun, Jan 27 2002, Richard Gooch wrote:
> > > > > Hi, all. Appended is my sd-many patch. It supports up to 2080
> > > > > SD's. This patch is against 2.4.18-pre7, and is essentially the same
> > > > > as earlier versions of this patch, just compensating for kernel drift.
> > > >
> > > > Could you please at least try to follow the style in sd? To me, this
> > > > alone is reason enough why the patch should not be applied.
> > >
> > > ??? I *have* followed the style. Or at least I've tried to. Where did
> > > I not?
> >
> > Are you serious?! You use
> +#ifdef CONFIG_SD_MANY
> +static inline int sd_devnum_to_index(int devnum)
> +{
> + int i, major = MAJOR (devnum);
> +
> + for (i = 0; i < sd_template.num_majors; ++i) {
> + if (sd_template.majors[i] != major)
> + continue;
> + return (i << 4) | (MINOR (devnum) >> 4);
> + }
> + return -ENODEV;
> +}
> +#endif
Apart from this one hunk, yeah it looks consistent and much better now.
-- Jens Axboe- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:00:49 EST