Re: Encountered a Null Pointer Problem on the SCSI Layer

• Next message: Horst von Brand: "Re: [PATCH] KERN_INFO for devfs"
• Previous message: Horst von Brand: "Re: A modest proposal -- We need a patch penguin"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Pete Zaitcev <zaitcev@redhat.com> said:
> > --- linux/drivers/scsi/sd.c Fri Jan 25 14:01:07 2002
> > +++ linux-2.4.17-diskio/drivers/scsi/sd.c Fri Jan 25 13:57:01 2002
> > @@ -279,7 +279,7 @@
> > target = DEVICE_NR(dev);
> >
> > dpnt = &rscsi_disks[target];
> > - if (!dpnt)
> > + if (!dpnt->device)
> > return NULL; /* No such device */
> > return &dpnt->device->request_queue;
> > }
>
> > Wai Yee Peter Wong
>
> There's one more of theese
>
> --- linux-2.4.18-pre1/drivers/scsi/sd.c Fri Nov 9 14:05:06 2001
> +++ linux-2.4.18-pre1-p3/drivers/scsi/sd.c Mon Jan 28 14:46:11 2002
> @@ -302,7 +302,7 @@
>
> dpnt = &rscsi_disks[dev];
> if (devm >= (sd_template.dev_max << 4) ||
> - !dpnt ||
> + !dpnt->device ||
> !dpnt->device->online ||
> block + SCpnt->request.nr_sectors > sd[devm].nr_sects) {
> SCSI_LOG_HLQUEUE(2, printk("Finishing %ld sectors\n", SCpnt->re
> quest.nr_sectors));

Is is possible for dpnt to be NULL here? Should perhaps be checked...

-- 
Horst von Brand			     http://counter.li.org # 22616
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Horst von Brand: "Re: [PATCH] KERN_INFO for devfs"
• Previous message: Horst von Brand: "Re: A modest proposal -- We need a patch penguin"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:01:14 EST