Re: [PATCH] IBM Lanstreamer bugfixes (round 2)

• Next message: Terje Eggestad: "Re: TCP/IP Speed"
• Previous message: Hans Reiser: "[PATCH] 2.4 ReiserFS rename bugfix"
• In reply to: Kent Yoder: "[PATCH] IBM Lanstreamer bugfixes (round 2)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

Very minor suggestion:

On Thu, Jan 31, 2002 at 09:29:21AM -0600, Kent Yoder wrote:
> + case IOCTL_SPIN_LOCK_TEST:
> + printk("spin_lock() called.\n");

You should add the proper KERN_* level to all of the printk() calls in
this ioctl function, as they do not seem to be protected with a
#ifdef STREAMER_DEBUG, like other unclassified printk() calls in this
driver are.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Terje Eggestad: "Re: TCP/IP Speed"
• Previous message: Hans Reiser: "[PATCH] 2.4 ReiserFS rename bugfix"
• In reply to: Kent Yoder: "[PATCH] IBM Lanstreamer bugfixes (round 2)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:01:35 EST