Re: [PATCH] amiga input api drivers

From: Simon Richter (Simon.Richter@phobos.fachschaften.tu-muenchen.de)
Date: Thu Jan 31 2002 - 18:56:07 EST

Next message: Dave Hansen: "Revealing unload_lock to everyone"
Previous message: Andrea Arcangeli: "Re: [PATCH] Radix-tree pagecache for 2.5"
In reply to: James Simmons: "Re: [PATCH] amiga input api drivers"
Next in thread: Roman Zippel: "Re: [PATCH] amiga input api drivers"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, 31 Jan 2002, James Simmons wrote:

> > > + scancode = scancode >> 1; /* lowest bit is release bit */
> > > + down = scancode & 1;

> > Shouldn't that be the other way 'round?

> I don't know. Anyone?

Me neither, this just looked weird to me, since this code is equivalent to

down = (scancode & 2) >> 1;
scancode = scancode >> 1;

and this is not what I'd expect from the comment. :-)

Simon

-- 
GPG public key available from http://phobos.fs.tum.de/pgp/Simon.Richter.asc
 Fingerprint: DC26 EB8D 1F35 4F44 2934  7583 DBB6 F98D 9198 3292
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Dave Hansen: "Revealing unload_lock to everyone"
Previous message: Andrea Arcangeli: "Re: [PATCH] Radix-tree pagecache for 2.5"
In reply to: James Simmons: "Re: [PATCH] amiga input api drivers"
Next in thread: Roman Zippel: "Re: [PATCH] amiga input api drivers"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:01:40 EST