Re: [PATCH] Generic HDLC patch for 2.5.3

From: Jeff Garzik (garzik@havoc.gtf.org)
Date: Sun Feb 03 2002 - 12:46:14 EST

Next message: Matt: "Re: stumped with APM suspend/resume problem going from 2.4.5 -> 2.4.17"
Previous message: Thomas Hood: "Re: stumped with APM suspend/resume problem going from 2.4.5 -> 2.4.17"
In reply to: Francois Romieu: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Next in thread: Francois Romieu: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Reply: Francois Romieu: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Reply: Krzysztof Halasa: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I like. This patch much improves things.

"SIOCDEVICE" as a constant is unacceptable, so it would need to be
SIOCWANDEVICE or something similar.

SIOCETHTOOL, for example, is an ioctl which actually provides
sub-ioctls, so that is probably a good model to follow.

More comments after I return from New York, and can review these at
length...

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Matt: "Re: stumped with APM suspend/resume problem going from 2.4.5 -> 2.4.17"
Previous message: Thomas Hood: "Re: stumped with APM suspend/resume problem going from 2.4.5 -> 2.4.17"
In reply to: Francois Romieu: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Next in thread: Francois Romieu: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Reply: Francois Romieu: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Reply: Krzysztof Halasa: "Re: [PATCH] Generic HDLC patch for 2.5.3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Feb 07 2002 - 21:00:28 EST