> Date: Tue, 19 Feb 2002 00:01:39 +0100
> From: Stephan von Krawczynski <skraw@ithnet.com>
> Are you 100% sure, that there is no case where
> dpnt==NULL? Because if there is such a possibility, your patch will
> blow up.
If there is such a possibility, everything will blow up.
Please bear with me while I am ranting at your expense, but
your example is very educational.
It seems to me that many people consider that putting a check
for NULL in front of every pointer dereference is an answer
to everything, including a missing understanding of the code.
It actually is not the case, IMHO. In well written code,
checks for NULL are not introduced to prevent oopses locally.
Instead, they implement a functionality, according to the
master plan. To distinguish these two conditions, mentally
consider a replacement of the check with something more descriptive.
When my eye sees a code that does this:
if (p->foo == NULL)
return -EINVAL;
my mind sees either this:
/*
* Our brains are too small to wrap arouund this module,
* and we saw an oops somewhere. Let's plug it with
* a check and pray that nobody will notice.
*/
if (p->foo == NULL)
return -EINVAL;
or this:
if (device_is_attached(dpnt))
return -EINVAL; /* XXX TODO: -ENODEV, not -EINVAL */
The code may be conductive to such interpretation by the mind,
or it may be not. In latter case we do what is called "a cleanup".
Often, the interpretation can only be done by looking at the
code as a whole, but this particular patch is nearly obvious
by itself:
> > dpnt = &rscsi_disks[target];
> > - if (!dpnt)
> > + if (!dpnt->device)
> > return NULL; /* No such device */
> > return &dpnt->device->request_queue;
The dpnt may be null ONLY if we do I/O to the first partition
of a first disk. Is anything special about that case?
I think not. Also, look at the comment. Obviously, the if() was
meant for something other than a corner case of partition zero.
It seems probable that the data layout was modified
but the check was forgotten.
-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Feb 23 2002 - 21:00:17 EST