Re: [RFC] Page table sharing

From: Daniel Phillips (phillips@bonn-fries.net)
Date: Fri Feb 22 2002 - 01:32:31 EST

Next message: J.A. Magallon: "Re: [PATCHSET] Linux 2.4.18-rc3-jam1"
Previous message: mailerror@hushmail.com: "loop under 2.2.20 - relative block support?"
In reply to: Daniel Phillips: "Re: [RFC] Page table sharing"
Next in thread: Daniel Phillips: "Re: [RFC] Page table sharing, leak gone"
Reply: Daniel Phillips: "Re: [RFC] Page table sharing, leak gone"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

The following gross mistake was noticed promptly by Rik van Riel:

        spin_lock(&page_table_share_lock);
- if (page_count(virt_to_page(pte)) == 1) {
+ if (put_page_testzero(virt_to_page(pte))) {
                pmd_clear(dir);
                pte_free_slow(pte);
        }
        spin_unlock(&page_table_share_lock);

However, oddly enough, that's not the memory leak.

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: J.A. Magallon: "Re: [PATCHSET] Linux 2.4.18-rc3-jam1"
Previous message: mailerror@hushmail.com: "loop under 2.2.20 - relative block support?"
In reply to: Daniel Phillips: "Re: [RFC] Page table sharing"
Next in thread: Daniel Phillips: "Re: [RFC] Page table sharing, leak gone"
Reply: Daniel Phillips: "Re: [RFC] Page table sharing, leak gone"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 23 2002 - 21:00:48 EST