Re: devfs: BKL *not* taken while opening devices

• Next message: David Woodhouse: "Re: How to enable printk"
• Previous message: Denis Vlasenko: "Re: How to enable printk"
• In reply to: Arjan van de Ven: "Re: devfs: BKL *not* taken while opening devices"
• Next in thread: Dave Hansen: "Re: devfs: BKL *not* taken while opening devices"
• Reply: Dave Hansen: "Re: devfs: BKL *not* taken while opening devices"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Apr 29, 2002 at 06:21:34PM +0100, Arjan van de Ven wrote:
> I'm not convinced of that. It's not nearly a critical path and it's
> better to get even the "dumb" drivers safe than to risk having big
> security holes in there for years to come.

Would it be worth dropping a BUG_ON(!kernel_locked()) in tty_open() to
catch this type of error? The tty code heavily relies on the BKL.

This way, such locking problems would get caught early, since everyone
uses the tty code during boot, right?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: David Woodhouse: "Re: How to enable printk"
• Previous message: Denis Vlasenko: "Re: How to enable printk"
• In reply to: Arjan van de Ven: "Re: devfs: BKL *not* taken while opening devices"
• Next in thread: Dave Hansen: "Re: devfs: BKL *not* taken while opening devices"
• Reply: Dave Hansen: "Re: devfs: BKL *not* taken while opening devices"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Apr 30 2002 - 22:00:19 EST