Should __daemonize() check this? check if in the arguments
tsk == current or tsk == idle_task. This would prevent people
from using __daemonize() for the wrong things.
Balbir
|-----Original Message-----
|From: linux-kernel-owner@vger.kernel.org
|[mailto:linux-kernel-owner@vger.kernel.org]On Behalf Of Rusty Russell
|Sent: Monday, May 13, 2002 7:31 AM
|To: BALBIR SINGH
|Cc: torvalds@transmeta.com; linux-kernel@vger.kernel.org
|Subject: Re: [PATCH] Hotplug CPU prep III: daemonize idle tasks
|
|
|In message <AAEGIMDAKGCBHLBAACGBAELNCHAA.balbir.singh@wipro.com> you write:
|> I tried a version of __daemonize in 2.4. It panics in
|> schedule()
|>
|> prepare_to_switch();
|> {
|> struct mm_struct *mm = next->mm;
|> struct mm_struct *oldmm = prev->active_mm;
|> if (!mm) {
|> if (next->active_mm) BUG();
|>
|> I got hit by the BUG() in 2.4, I think prepare_to_switch has
|> moved to specific archs in 2.5. A quick look showed that
|> this issue no longer exists in 2.5.
|
|Uhhh... there are many other problems if you are trying to do this on
|a "live" process. idle process creation is a special case because it
|has never been run yet.
|
|This is not a generic "daemonize this task" mechanism!
|Rusty.
|--
| Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
|-
|To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
|the body of a message to majordomo@vger.kernel.org
|More majordomo info at http://vger.kernel.org/majordomo-info.html
|Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue May 14 2002 - 12:00:19 EST