Re: [patch] New driver for Artop [Acard] controllers.

• Next message: Alan Cox: "Re: 20275 linux driver patch dated 3/7/2002"
• Previous message: Alan Cox: "Re: [PATCH] SUSv2 msgctl compliance"
• Maybe in reply to: Vojtech Pavlik: "[patch] New driver for Artop [Acard] controllers."
• Next in thread: Martin Dalecki: "Re: [patch] New driver for Artop [Acard] controllers."
• Reply: Martin Dalecki: "Re: [patch] New driver for Artop [Acard] controllers."
• Reply: Vojtech Pavlik: "Re: [patch] New driver for Artop [Acard] controllers."
• Reply: Vojtech Pavlik: "Re: [patch] New driver for Artop [Acard] controllers."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi!

I have a very quick look over patch/driver... looks quite ok...

But it doesn't support multiple controllers. We should add 'unsigned
long private' to 'ata_channel struct' and store index in the chipset
table there.
You can remove duplicate entries from module data table.

BTW: please don't touch pdc202xx.c I am playing with it...

greets

--
bkz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Alan Cox: "Re: 20275 linux driver patch dated 3/7/2002"
• Previous message: Alan Cox: "Re: [PATCH] SUSv2 msgctl compliance"
• Maybe in reply to: Vojtech Pavlik: "[patch] New driver for Artop [Acard] controllers."
• Next in thread: Martin Dalecki: "Re: [patch] New driver for Artop [Acard] controllers."
• Reply: Martin Dalecki: "Re: [patch] New driver for Artop [Acard] controllers."
• Reply: Vojtech Pavlik: "Re: [patch] New driver for Artop [Acard] controllers."
• Reply: Vojtech Pavlik: "Re: [patch] New driver for Artop [Acard] controllers."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri May 31 2002 - 22:00:13 EST