Anders Gustafsson wrote:
>On Thu, Jun 06, 2002 at 07:02:08PM +0200, Svetoslav Slavtchev wrote:
>
>
>>Hi ,
>>i was trying to get the patch from Anders Gustafsson working in 2.5.20,
>>but i'm getting by compilation:
>>....
>>lvm.c: In function `__update_hardsectsize':
>>lvm.c:2021: warning: implicit declaration of function `get_hardsect_size'
>>
>>
>
>
>[.. snip ..]
>
>
>
>> /* only perform this operation on active snapshots */
>> if ((lv->lv_access & LV_SNAPSHOT) &&
>> (lv->lv_status & LV_ACTIVE)) {
>> for (e = 0; e < lv->lv_remap_end; e++) {
>> hardsectsize = get_hardsect_size(
>>lv->lv_block_exception[e].rdev_new);
>>
>>
>
>snapshotting doesn't work anyhow, so this block could be removed 'til
>its unbroked.
>
thanks, i had a similar solution , but i wasn't shure
i'll try it with a 2.5.20-dj3 or dj4
--- linux-2.5.18/drivers/md/lvm.c 2002-06-04 17:25:40.000000000 +0200
+++ linux-2.5.20-dj3-lvm-xfs-w3/drivers/md/lvm.c 2002-06-08
19:08:41.000000000 +0200
@@ -216,6 +216,7 @@
#include <linux/stat.h>
#include <linux/fs.h>
#include <linux/proc_fs.h>
+#include <linux/buffer_head.h> /* for invalidate_buffers */
#include <linux/blkdev.h>
#include <linux/genhd.h>
#include <linux/devfs_fs_kernel.h>
@@ -2014,17 +2015,23 @@
max_hardsectsize = hardsectsize;
}
+
+ /* FROM ME SVETLJO, otherweise it doesnt compile
+ * get_hardsect_size had disapeared in 2.5.18
+ */
/* only perform this operation on active snapshots */
- if ((lv->lv_access & LV_SNAPSHOT) &&
+/* if ((lv->lv_access & LV_SNAPSHOT) &&
(lv->lv_status & LV_ACTIVE)) {
for (e = 0; e < lv->lv_remap_end; e++) {
- hardsectsize = get_hardsect_size(
lv->lv_block_exception[e].rdev_new);
+ hardsectsize = get_hardsect_size(
lv->lv_block_exception[e].rdev_new);
if (hardsectsize == 0)
hardsectsize = 512;
if (hardsectsize > max_hardsectsize)
max_hardsectsize = hardsectsize;
}
}
+*/
+
}
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:13 EST