2.5.21: kbuild changes broke filenames with commas

From: Russell King (rmk@arm.linux.org.uk)
Date: Sun Jun 09 2002 - 11:58:04 EST


With the latest kbuild version in 2.5.21, we are unable to build the
following files:

linux/drivers/block/smart1,2.h
linux/drivers/scsi/53c7,8xx.c
linux/drivers/scsi/53c7,8xx.h
linux/drivers/scsi/53c7,8xx.scr
linux/arch/arm/mm/proc-arm6,7.S
linux/arch/arm/mm/proc-arm2,3.S

This is because we end up passing gcc the following argument:

        -Wp,-MD,.proc-arm6,7.o.d

which gets passed to cpp0 as:

        -MD .proc-arm6 7.o.d
                      ^ space, not comma

and therefore cpp0 sees "-MD", ".proc-arm6" and "7.o.d" as separate
arguments.

There seems to be two solutions:

1. renaming all the above files to contain '_' instead of ','.
2. see if kbuild can use the DEPENDENCIES_OUTPUT environment variable

Kai pointed out that we've already got one exception in kbuild to fixup
the filename for KBUILD_BASENAME (, -> _ and that's not a weird smilie!)
so (1) is probably going to be better, and we can get rid of the special
"comma" handling.

Either way, I plan to rename the two ARM files. That leaves the 53c7,8xx
driver and that block header file.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:14 EST