Re: [PATCH] 2.5.21 - list.h cleanup

From: Manik Raina (manik@cisco.com)
Date: Mon Jun 10 2002 - 12:26:24 EST


> The linux coding style _tends_ to avoid using typedefs. It's not a hard
> rule (and I did in fact apply this patch, since it otherwise looked fine),
> but it's fairly common to use an explicit "struct xxxx" instead of
> "xxxx_t".
>

        Besides , if someone's browsing the code using 'gid' one would
        have to first discover where xxxx_t is defined and realise it's
        typedef'ed to struct _xxxx_t and then we'd start to find where
        the heck _xxxx_t is .

        I'm not saying code needs to be written keeping in mind ease
        with which we can run code browsing tools, but avoiding unnecessary
        typedefs can certainly help here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:18 EST