Hi,
On Mon, 10 Jun 2002, Jacob Luna Lundberg wrote:
> On Mon, 10 Jun 2002, Thunder from the hill wrote:
> > - printk(KERN_WARNING "i2o: Could not quiesce %s." "
> > - Verify setup on next system power up.\n", c->name);
> > + printk(KERN_WARNING "i2o: Could not quiesce %s."
> > + "Verify setup on next system power up.\n",
> > + c->name);
>
> Don't we lose a \n if you do that? Speaking of, is "\n" better, or " "
> I wonder... ;)
You're right, here comes the accurate version:
Index: drivers/message/i2o/i2o_core.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/message/i2o/i2o_core.c,v
retrieving revision 1.1
diff -u -3 -p -r1.1 i2o_core.c
--- thunder-2.5/drivers/message/i2o/i2o_core.c 10 Jun 2002 15:17:07 -0000 1.1
+++ thunder-2.5/drivers/message/i2o/i2o_core.c 11 Jun 2002 01:22:10 -0000
@@ -3407,8 +3407,9 @@ static int i2o_reboot_event(struct notif
{
if(i2o_quiesce_controller(c))
{
- printk(KERN_WARNING "i2o: Could not quiesce %s." "
- Verify setup on next system power up.\n", c->name);
+ printk(KERN_WARNING "i2o: Could not quiesce %s.\n"
+ "Verify setup on next system power up.\n",
+ c->name);
}
}
Index: drivers/hotplug/cpqphp_nvram.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/hotplug/cpqphp_nvram.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -3 -p -r1.1 -r1.2
--- thunder-2.5/drivers/hotplug/cpqphp_nvram.c 10 Jun 2002 15:13:54 -0000 1.1
+++ thunder-2.5/drivers/hotplug/cpqphp_nvram.c 11 Jun 2002 00:54:24 -0000 1.2
@@ -176,12 +176,12 @@ static u32 access_EV (u16 operation, u8
spin_lock_irqsave(&int15_lock, flags);
__asm__ (
- "xorl %%ebx,%%ebx
- xorl %%edx,%%edx
- pushf
- push %%cs
- cli
- call *%6"
+ "xorl %%ebx,%%ebx \n"
+ "xorl %%edx,%%edx \n"
+ "pushf \n"
+ "push %%cs \n"
+ "cli \n"
+ "call *%6 \n"
: "=c" (*buf_size), "=a" (ret_val)
: "a" (op), "c" (*buf_size), "S" (ev_name),
"D" (buffer), "m" (compaq_int15_entry_point)
Regards,
Thunder
--
German attitude becoming | Thunder from the hill at ngforever
rightaway popular: |
"Get outa my way, | free inhabitant not directly
for I got a mobile phone!" | belonging anywhere
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:20 EST