Re: [PATCH] 2.5.21 - list.h cleanup

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Tue Jun 11 2002 - 04:14:51 EST


In message <Pine.LNX.4.44.0206110128130.1987-100000@home.transmeta.com> you wri
te:
>
>
> On Tue, 11 Jun 2002, Rusty Russell wrote:
> >
> > Worst sin is that you can't predeclare typedefs. For many uses (not the
> > list macros of course):
> > struct xx;
> > is sufficient and avoids the #include hell,
>
> True.
>
> However, that only works for function declarations.

Our headers basically consist of:

1) Macros
2) Structure declarations
3) Function declarations
4) Inline functions

The number of structures and functions which need only "struct xxx *"
is very high: removing typedefs is something about with ~zero pain
(unlike dropping the sometimes-dubious loveaffair with inlines).

Rusty.
PS. I blame Ingo: list_t indeed!

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:21 EST