Re: 2.5.21: kbuild changes broke filenames with commas

From: Daniel Phillips (phillips@bonn-fries.net)
Date: Tue Jun 11 2002 - 11:08:22 EST


On Tuesday 11 June 2002 09:39, Russell King wrote:
> On Tue, Jun 11, 2002 at 09:02:45AM +1000, Keith Owens wrote:
> > >linux/drivers/block/smart1,2.h
> > >linux/drivers/scsi/53c7,8xx.c
> > >linux/drivers/scsi/53c7,8xx.h
> > >linux/drivers/scsi/53c7,8xx.scr
> > >linux/arch/arm/mm/proc-arm6,7.S
> > >linux/arch/arm/mm/proc-arm2,3.S
> >
> > kbuild 2.5 can handle filenames with ',' in the name. I do not believe
> > in restricting what users can do unless there is absolutely no
> > alternative. In this case a smarter build system can handle special
> > filenames.
>
> I've already fixed up the two ARM ones. That leaves one problematic
> file - 53c7,8xx.c.
>
> Is it really worth adding complexity to a build system to work around
> what is really a GCC bug for just one file? I don't think so.

Are you sure that complexity was added just to handle commas in names?
Or is it really an example of how good design never gave this bug a
chance to exist in the first palce.

I *really* don't like the idea of papering over such bugs by curing the
symptoms, as you seem to be advocating.

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:22 EST