Re: [PATCH, TRIVIAL] Fix argument of BLKGETSIZE64

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Wed Jun 12 2002 - 00:41:23 EST

Next message: Brad Hards: "Re: Parallel Port and USB Device Drivers"
Previous message: Rusty Russell: "Re: [PATCH] Futex Asynchronous Interface"
In reply to: Peter Chubb: "[PATCH, TRIVIAL] Fix argument of BLKGETSIZE64"
Next in thread: Peter Chubb: "Re: [PATCH, TRIVIAL] Fix argument of BLKGETSIZE64"
Reply: Peter Chubb: "Re: [PATCH, TRIVIAL] Fix argument of BLKGETSIZE64"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <15622.54728.469214.307901@wombat.chubb.wattle.id.au> you write:
>
> (2.5.21) The third argument to BLKGETSIZE64 is declared as u64 in
> include/linux/fs.h
...
> -#define BLKGETSIZE64 _IOR(0x12,114,sizeof(u64)) /*
> +#define BLKGETSIZE64 _IOR(0x12,114,sizeof(uint64_t)) /*

This is a wider question: uint64_t and int64_t (et. al) are ISO C
<stdint.h> requirements. Whether we should begin migration in 2.5, or
leave them alone is a Linus question.

> I think it should be uint64_t to allow glibc to copy and mangle the file into
> its header tree.

I don't think that's really an issue, is it?
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Brad Hards: "Re: Parallel Port and USB Device Drivers"
Previous message: Rusty Russell: "Re: [PATCH] Futex Asynchronous Interface"
In reply to: Peter Chubb: "[PATCH, TRIVIAL] Fix argument of BLKGETSIZE64"
Next in thread: Peter Chubb: "Re: [PATCH, TRIVIAL] Fix argument of BLKGETSIZE64"
Reply: Peter Chubb: "Re: [PATCH, TRIVIAL] Fix argument of BLKGETSIZE64"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:24 EST