Re: 2.4.19-pre10 link error - cpqarray related ?

• Next message: Vincent Hanquez: "Re: Getting Started..."
• Previous message: Paul Menage: "Re: [PATCH] Push BKL into ->permission() calls"
• In reply to: Filip Sneppe: "2.4.19-pre10 link error - cpqarray related ?"
• Next in thread: White, Charles: "RE: 2.4.19-pre10 link error - cpqarray related ?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 18 Jun 2002, Filip Sneppe wrote:

> Hi,

Hi Filip,

first of all thanks for your report!

> I ran into some problems doing a "make bzImage" on 2.4.19-pre10:
>...
> drivers/block/block.o(.data+0xc54): undefined reference to `local
> symbols in discarded section .text.exit'
> make: *** [vmlinux] Error 1
>...
> After looking at the changelog and my kernel options, I found that
> the compilation failed when:
>
> CONFIG_BLK_CPQ_DA=y
> CONFIG_BLK_CPQ_CISS_DA=y
>...

The following patch fixes it (cpqarray_remove_one is __devexit but the
pointer to it didn't use __devexit_p):

--- drivers/block/cpqarray.c.old Tue Jun 18 10:19:55 2002
+++ drivers/block/cpqarray.c Tue Jun 18 10:30:27 2002
@@ -602,7 +602,7 @@
 static struct pci_driver cpqarray_pci_driver = {
         name: "cpqarray",
         probe: cpqarray_init_one,
- remove: cpqarray_remove_one,
+ remove: __devexit_p(cpqarray_remove_one),
         id_table: cpqarray_pci_device_id,
 };

> Kind regards,
> Filip
>...

cu
Adrian

-- 
You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Vincent Hanquez: "Re: Getting Started..."
• Previous message: Paul Menage: "Re: [PATCH] Push BKL into ->permission() calls"
• In reply to: Filip Sneppe: "2.4.19-pre10 link error - cpqarray related ?"
• Next in thread: White, Charles: "RE: 2.4.19-pre10 link error - cpqarray related ?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:15 EST