Re: n_tty.c driver patch (semantic and performance correction) (a ll recent versions)

• Next message: Matthew Wilcox: "[PATCH] remove tqueue.h from sched.h"
• Previous message: Morten Helgesen: "[RFC] Getting rid of check_region()"
• In reply to: Robert White: "Re: n_tty.c driver patch (semantic and performance correction) (a ll recent versions)"
• Next in thread: Dax Kelson: "Anyone using NFSv4?"
• Reply: Dax Kelson: "Anyone using NFSv4?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: "Robert White" <rwhite@pobox.com>
> should you use your greater-access to the code and user base, you would
find
> a single case where it breaks, invalidates, or confuses a single person or
> program on the planet.

I can see one easy case: protocol has frame size of N. VMIN is set to
say 3 * N. read() supplies a buffer of N. The purpose being that the
first read will block until 3 frames are ready to process, then return
the first one. Your patch would break that.

Having said that, I don't know of any instances where the above is
employed. I'd say your patch is worthwhile.

..Stu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Matthew Wilcox: "[PATCH] remove tqueue.h from sched.h"
• Previous message: Morten Helgesen: "[RFC] Getting rid of check_region()"
• In reply to: Robert White: "Re: n_tty.c driver patch (semantic and performance correction) (a ll recent versions)"
• Next in thread: Dax Kelson: "Anyone using NFSv4?"
• Reply: Dax Kelson: "Anyone using NFSv4?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:16 EST